Delete some of our logos (part 1); affects [endpoint] #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gah - I'd forgotten that there are some tests and services which directly reference logos - thanks, Continuous Integration! I'll come back to this and get all the tests passing tomorrow. The visuals shouldn't change though. |
|
Nice work on this, looking really good 👍 |
|
Nice! The tables really are so much work, it's cool this is moving ahead. Re two of these:
|
chris48s
changed the title
|
mostly non-controversial ;) |
paulmelnikow
previously approved these changes
Jan 25, 2019
# Conflicts: # core/base-service/base.spec.js
paulmelnikow
dismissed stale reviews from calebcartwright and themself
via
9b3deb6
paulmelnikow
approved these changes
Jan 25, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2510
I'm going to delete or change some more logos in a further PR or two, but lets start off with the (hopefully) non-controversial ones. I think in all of these cases it is fairly clear-cut that we are not losing anything by removing our icon in favour of simple-icons now that we apply a sensible colour by default.
**Note this one is out-of-date now, but there's a PR open to update to the new slack logo: simple-icons/simple-icons#1172 This is one of the other nice things about not maintaining our own logos.There are a few more to go, but I'll be quite glad when I don't need to make any more of these tables! :)