Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a diagnostic page for testing logos #2890

Merged
merged 5 commits into from
Feb 8, 2019
Merged

Conversation

paulmelnikow
Copy link
Member

It can be helpful to have some diagnostic pages for development and quality control. I added one here for the logos, which renders all the named logos in ?style=flat and ?style=social.

It can be helpful to have some diagnostic pages for development and quality control. I added one here for the logos, which renders all the named logos in ?style=flat and ?style=social.
@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Jan 28, 2019
@shields-ci
Copy link

shields-ci commented Jan 28, 2019

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against 56f1d0a

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2890 January 28, 2019 23:28 Inactive
@chris48s
Copy link
Member

On staging this hit Exceeded limit 500 requests per 200 seconds halfway through loading the page :D

Are you thinking this is something to expose to end users, or something for local development use?

@paulmelnikow
Copy link
Member Author

No, not end users, but it's useful in development. It would be nice if we didn't run into rate limits like this on staging!

@calebcartwright
Copy link
Member

Another observation (not sure if this is expected or not), but some of the logos on the social badges at the top of the page are missing for me:

image

@paulmelnikow
Copy link
Member Author

paulmelnikow commented Jan 30, 2019

The page is doing its job!

Another observation (not sure if this is expected or not), but some of the logos on the social badges at the top of the page are missing for me:

Confirmed. I guess there is some pending work to recolor those logos so they are visible on the social badge.

Added: lgtm and travis are mentioned at #2510 (comment)

@chris48s
Copy link
Member

chris48s commented Feb 4, 2019

Yes - there are definitely some light logo on light background issues with our bespoke logo set

It would be quite nice to make this view (and potentially other 'debug' views we might want to declare) available in dev, but not in production. I've slightly lost track of this in the settings re-organisation, but at the point we build the front-end, do we have an env var available that indicates prod/dev? i.e: can we declare the route conditionally on proceess.env.ENVIRONMENT == 'dev' or something so it exists in local dev, but not when we do the optimised production build?

@paulmelnikow
Copy link
Member Author

i.e: can we declare the route conditionally on proceess.env.ENVIRONMENT == 'dev' or something so it exists in local dev, but not when we do the optimised production build?

That sounds good. Let's get #2906 merged and then revisit this.

@paulmelnikow paulmelnikow requested a deployment to shields-staging-pr-2890 February 8, 2019 05:07 Abandoned
@paulmelnikow
Copy link
Member Author

We still may need to solve the rate limiting, though even with it, I think this page remains more useful than not.

@paulmelnikow paulmelnikow changed the title Add a dev page for testing logos Add a diagnostic page for testing logos Feb 8, 2019
@paulmelnikow paulmelnikow merged commit ae37e9b into master Feb 8, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants