-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [Treeware] badge #4814
Add [Treeware] badge #4814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I've left a couple of comments inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
module.exports = class TreewareTrees extends BaseJsonService { | ||
static get category() { | ||
return 'other' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have a funding
category, Not sure which one is more appropriate, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure about this, I guess funding is probably more appropriate. 👍
@jamesmills, I was just interested what you'd suggest for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that funding
would be okay, but I want to throw in license
as well. Because it's part of the license and not an optional funding.
The point is that every user is required to be trees if he uses the Treeware licensed software in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually leave it to the package maintainer to decide how to work the Treeware "condition of use". We currently have two in the wild.
This package is free and open-source, under the MIT license. Use it however you want. This package is Treeware. If you use it in production, then we ask that you buy the world a tree to thank us for our work.
You're free to use this package, but if it makes it to your production environment you are required to buy the world a tree.
In the first example, it's attached to the licence. However, the maintainer can decide how to word it.
I think it's a licence and would be happiest with this option.
I've applied the requested review comments, and commented where necessary. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go. The fact that we're not sure which category to put it in is probably an indication that "other" is OK
Thanks for your work on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, let's get this merged! Thanks for addressing the review comments promptly! 👍
Thanks for merging it! 🚀 Is there any plan on when this will be deployed? |
@Gummibeer deployments happen on a regular basis, but it's a manual step that can only be done by a couple of the maintainers. So no precise ETA, but hopefully it won't be too long! |
@platan there's no shields-deployment bot message here, any idea why? 🤔 |
@PyvesB Thanks for reporting this problem. |
This is related to #4728, it adds a badge for the Treeware project.
The badge this adds contains tests, and displays the trees that have been planted by a package (based on a referer hash).