Adding badges for JetBrains Plugin Ratings, run [JetBrainsRating]. #4897 #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chris48s
reviewed
Apr 11, 2020
calebcartwright
changed the title
|
Awesome, thank you, @chris48s !! I also saw in the contribution docs that the @shield-deployment bot should have come along with a message - but it seems that failed. I'm assuming that since this change was merged into master it'll go out with the next deploy, correct? :) |
Correct. Sometimes the deployment bot message just doesn't get posted for whatever reason |
|
Ok cool - I saw a few others where the deployment bot also didn't post. Looking forward to seeing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Please review this PR - first time doing node development, but followed existing JetBrains badge patterns among other badges. Added tests and tested via the local web interface.