npm total downloads support

[sagiegurari]

This adds support for the total downloads for the given project.
I use the range rest service of npm to fetch the info.

[sagiegurari]

any updates on this one?

[espadrine]

Could we include that piece in the try block please?

[espadrine]

Thanks for contributing! This looks great!

If you could use 2-space indentation to stay consistent with the rest, it would be great.

[sagiegurari]

Thanks, I'll be able to do the changes 2 days from now and I'll update the pull request.

[sagiegurari]

1. updated tabbing to 2 spaces
2. put var index inside for loop definition (although actually not best practice)
3. expanded the try/catch block to hold all logic
4. I didn't change the encodeURIComponent to encodeURI since i'm pretty sure its the right thing and its also consistent with rest of the server.js file.

[espadrine]

I didn't change the encodeURIComponent to encodeURI since i'm pretty sure its the right thing and its also consistent with rest of the server.js file.

In this particular case, it is a bit irrelevant. In the general case, escaping & is not necessary in the path.

See the difference between https://img.shields.io/badge/build-%26passing-brightgreen.svg?label=test%26 and https://img.shields.io/badge/build-&passing-brightgreen.svg?label=test&.

Thanks!

[sagiegurari]

Thanks for the merge.
I admit that I did this pull request because I want to use that badge :)
When do you deploy changes to your servers?

[espadrine]

I admit that I did this pull request because I want to use that badge :)

That's the best reason!

When do you deploy changes to your servers?

In 24h. That way, even when I'm on a bad day, I have the next day to realize if there's something I did wrong.

[sagiegurari]

Great, thanks a lot.