[GitHubReleaseDate] - published_at field #8543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chris48s
reviewed
Oct 18, 2022
chris48s
reviewed
Oct 19, 2022
Comment on lines
95
to
108
| if (Array.isArray(body)) { | ||
| if (queryParams.display_date === 'published_at') { | ||
| return this.constructor.render({ date: body[0].published_at }) | ||
| } | ||
|
|
||
| return this.constructor.render({ date: body[0].created_at }) | ||
| } | ||
|
|
||
| if (queryParams.display_date === 'published_at') { | ||
| return this.constructor.render({ date: body.published_at }) | ||
| } | ||
|
|
||
| return this.constructor.render({ date: body.created_at }) | ||
| } |
There was a problem hiding this comment.
In javascript you can address an object property defined by a variable using square brackets, so you should be able to reduce all this to just
if (Array.isArray(body)) {
return this.constructor.render({ date: body[0][queryParams.display_date] })
}
return this.constructor.render({ date: body[queryParams.display_date] })There was a problem hiding this comment.
Neat, thanks. Updated.
chris48s
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6309
For the GitHub Release Date badge by default we still use the
created_atfield.Now, if the user gives the
display_date=published_atquery param, that field from the API response would be used.https://api.github.com/repos/microsoft/vscode/releases/latest
http://localhost:8080/github/release-date/microsoft/vscode
http://localhost:8080/github/release-date/microsoft/vscode?display_date=published_at