Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[twitter] --> x #9496

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[twitter] --> x #9496

merged 1 commit into from
Aug 23, 2023

Conversation

chris48s
Copy link
Member

Closes #9479

I'm not going to get too bogged down in moving routes and files around as this is really just a pretty deprecation message, but this PR updates the name of the services in the docs and the default logo.

If you're explicitly using logo=twitter, then you'll continue to get the twitter logo. If simple-icons decide to make that slug an alias for the x logo in future, we'll inherit that decision.

@chris48s chris48s added the service-badge New or updated service badge label Aug 21, 2023
@github-actions
Copy link
Contributor

Warnings
⚠️ This PR modified service code for twitter but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 33a98e6

@chris48s chris48s added this pull request to the merge queue Aug 23, 2023
Merged via the queue into badges:master with commit 384fa4d Aug 23, 2023
20 checks passed
@chris48s chris48s deleted the 9479-twitter-x branch August 23, 2023 19:58
@AlexWayfer
Copy link

Honestly, default label also should be changed from Tweet to Post:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update name and logo from Twitter to X
3 participants