improve documentation for [dynamicxml] service #9798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
service-badge
chris48s
commented
Dec 10, 2023
Comment on lines
+21
to
+24
| Note: For XML documents that use a default namespace prefix, you will need to use the | ||
| [local-name](https://developer.mozilla.org/en-US/docs/Web/XPath/Functions/local-name) | ||
| function to construct your query. | ||
| For example \`/*[local-name()='myelement']\` rather than \`/myelement\`. |
There was a problem hiding this comment.
@Washingtonwei - a question for you here: If this had been in the documentation on the website, do you think this would have been enough to allow you to work out #9784 without raising an issue?
If not, can you suggest any improvements that don't relate to a specific XML document?
calebcartwright
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from #9784
I've attempted to document the point raised there, although I found it slightly tricky to explain it in a completely general way without referencing an example.
I also made a couple of other minor improvements while I was there.