[CratesMSRV] Badge #9871
Merged
[CratesMSRV] Badge #9871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failure is not in a file that i modified? EDIT: failing test case: // in crates-downloads.tester.js
t.create('downloads (invalid version)')
.get('/d/libc/7.json')
.expectBadge({ label: 'crates.io', message: 'invalid semver: 7' })the actual message was "not found" no clue how this happened |
|
🚀 Updated review app: https://pr-9871-badges-shields.fly.dev |
chris48s
reviewed
Jan 6, 2024
Sky9x
force-pushed
the
crates-msrv
branch
3 times, most recently
from
de13234
to
5083ab5
Compare
|
should be good to go unless you have any more suggestions |
|
🚀 Updated review app: https://pr-9871-badges-shields.fly.dev |
Crates.io MSRV: `/crates/msrv/:crate` Crates.io MSRV (version): `/crates/msrv/:crate/:version`
chris48s
approved these changes
Jan 7, 2024
Merged
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed in #9733
Routes:
Crates.io MSRV:
/crates/msrv/:crateCrates.io MSRV (version):
/crates/msrv/:crate/:version