Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4.2 and Xcode 10 #521

Merged
merged 8 commits into from
Dec 11, 2018
Merged

Swift 4.2 and Xcode 10 #521

merged 8 commits into from
Dec 11, 2018

Conversation

AntonPalich
Copy link
Contributor

This is PR to add Swift 4.2 and Xcode 10 support

@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #521 into master will increase coverage by 1.04%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   62.88%   63.93%   +1.04%     
==========================================
  Files          77       76       -1     
  Lines        4063     3679     -384     
==========================================
- Hits         2555     2352     -203     
+ Misses       1508     1327     -181
Impacted Files Coverage Δ
...otos/PhotosInputWithPlaceholdersDataProvider.swift 80.76% <ø> (ø) ⬆️
...s/PhotoMessageCollectionViewCellDefaultStyle.swift 75.36% <ø> (-5.66%) ⬇️
...aceholder/PhotosInputPlaceholderCellProvider.swift 0% <ø> (ø) ⬆️
...ws/TextMessageCollectionViewCellDefaultStyle.swift 89.87% <ø> (+5.06%) ⬆️
...dditions/Source/Input/Photos/PhotosInputView.swift 1.51% <ø> (+0.09%) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 82.02% <ø> (+7.72%) ⬆️
...eMessage/Views/BaseMessageCollectionViewCell.swift 61.13% <ø> (-1.05%) ⬇️
...e/Input/Photos/Photo/PhotosInputDataProvider.swift 0% <0%> (ø) ⬆️
...Source/Input/Photos/Camera/DeviceImagePicker.swift 0% <0%> (ø) ⬆️
...ntroller/Collaborators/AccessoryViewRevealer.swift 30.76% <0%> (+1.92%) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1016906...420dc9b. Read the comment docs.

@caquillo07
Copy link

You are an angel, we need to get this

@igrrik
Copy link

igrrik commented Oct 25, 2018

Does anybody know when this PR will be merged?

@AntonPalich
Copy link
Contributor Author

It will be merged after Badoo migrate to Swift 4.2. Don't expect it very soon. Meanwile, you can use branch swift_4.2 if needed. It will be up-to-date with master

@geegaset
Copy link
Contributor

geegaset commented Nov 1, 2018

You are an angel!

@AntonPalich AntonPalich merged commit 09f4f54 into master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants