Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing of item presenters #596

Merged
merged 19 commits into from
Aug 23, 2019
Merged

Conversation

MikhailGasanov
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 29, 2019

Codecov Report

Merging #596 into master will increase coverage by 1.05%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   57.91%   58.97%   +1.05%     
==========================================
  Files          91       91              
  Lines        3883     3946      +63     
==========================================
+ Hits         2249     2327      +78     
+ Misses       1634     1619      -15
Impacted Files Coverage Δ
...ource/Chat Items/ChatItemProtocolDefinitions.swift 50% <ø> (+33.33%) ⬆️
...sage/Content/MessageContentPresenterProtocol.swift 0% <ø> (ø) ⬆️
...poundMessage/CompoundMessagePresenterBuilder.swift 0% <ø> (ø) ⬆️
...e/Chat Items/PhotoMessages/PhotoMessageModel.swift 60% <0%> (-40%) ⬇️
...tto/Source/Chat Items/DummyChatItemPresenter.swift 66.66% <0%> (-13.34%) ⬇️
...atto/Source/Chat Items/BaseChatItemPresenter.swift 50% <0%> (-9.1%) ⬇️
...rce/Chat Items/TextMessages/TextMessageModel.swift 62.5% <0%> (-37.5%) ⬇️
...Chat Items/TextMessages/TextMessagePresenter.swift 68.62% <0%> (-2.81%) ⬇️
...at Items/PhotoMessages/PhotoMessagePresenter.swift 68.18% <0%> (-3.25%) ⬇️
...hatController/BaseChatViewController+Changes.swift 90.86% <100%> (+0.3%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1da3a3...be04c3f. Read the comment docs.

@MikhailGasanov MikhailGasanov merged commit ade6d67 into master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants