Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BUILD_LIBRARY_FOR_DISTRIBUTION option #626

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

dive
Copy link
Member

@dive dive commented Nov 7, 2019

We have to disable the option due to two blockers with Swift Toolchain: SR-11704, SR-11466.

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #626 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   60.69%   60.82%   +0.12%     
==========================================
  Files          92       92              
  Lines        4898     4898              
==========================================
+ Hits         2973     2979       +6     
+ Misses       1925     1919       -6
Impacted Files Coverage Δ
...Chat Items/TextMessages/Views/TextBubbleView.swift 86.22% <0%> (+3.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25cf300...3ca63d0. Read the comment docs.

@MikhailGasanov MikhailGasanov merged commit af4956d into master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants