Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind dependency in Dagger templates with @BindsInstance in Factory #144

Closed
zsoltk opened this issue Apr 7, 2020 · 0 comments
Closed

Bind dependency in Dagger templates with @BindsInstance in Factory #144

zsoltk opened this issue Apr 7, 2020 · 0 comments
Assignees
@zsoltk
Labels
enhancement New feature or request

Comments

@zsoltk
Copy link
Contributor

zsoltk commented Apr 7, 2020

This will make it clear in Dagger modules what's coming from where (compared to unpacking them when using dependency in Component annotation). Build params will already be explicit.
@zsoltk zsoltk added the enhancement New feature or request label Apr 7, 2020
@zsoltk zsoltk self-assigned this Apr 7, 2020
@zsoltk zsoltk closed this as completed in 1e7c64e Apr 9, 2020
zsoltk added a commit that referenced this issue Apr 9, 2020
@zsoltk
Merge pull request #149 from zsoltk/template-dependencies
54f50c1 
Bind external dependencies with @BindsInstance. Fixes #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zsoltk zsoltk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zsoltk