Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Dimension response #7

Closed
wants to merge 1 commit into from
Closed

Conversation

cgoessen
Copy link

This allow "Dimension responses" to be parsed.

@badosa
Copy link
Owner

badosa commented May 31, 2016

This allow "Dimension responses" to be parsed.

Really? Did you try it against a dimension response? Do you have a working example?

I checked your request and it doesn't seem to work as expected (I can point two or three places in the code that also require changes).

@cgoessen
Copy link
Author

You are right, I was to quick to judge.

This doesn't return a valid dimension response. I was so focused on getting rid of the processing error I did not pay attention to the return value.

I'll look into it if I can figure out what's wrong.

@badosa
Copy link
Owner

badosa commented May 31, 2016

If you want, I can take care of it (in a week or so).

@cgoessen
Copy link
Author

cgoessen commented Jun 1, 2016

That would be much appreciated, I'm still trying to figure out your code.
You'd be more efficient at this one for sure.

@badosa badosa closed this Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants