Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension always displaying off (disabled) #54

Closed
joeroback opened this issue Jan 5, 2022 · 42 comments · Fixed by #55
Closed

Extension always displaying off (disabled) #54

joeroback opened this issue Jan 5, 2022 · 42 comments · Fixed by #55
Labels
bug Something isn't working

Comments

@joeroback
Copy link

joeroback commented Jan 5, 2022

Pi-hole v5.8.1
FTL v5.13
Web Interface v5.10.1

basically i think the call to /admin/api.php has changed, such that this extension no longer correctly see pihole as running.

@joeroback joeroback added the bug Something isn't working label Jan 5, 2022
@JeromeX
Copy link

JeromeX commented Jan 6, 2022

same here, after update to the latest version. It shows off but it's still on

image
image
image

@joeroback
Copy link
Author

I just filed this: pi-hole/web#2051

unclear what the API call should be, since its not documented, that being said, my PiHole iOS app is working fine with the latest updates...

@badsgahhl
Copy link
Owner

Oh wow. Thanks for reporting that. This will be fixed with v3.0.1.

badsgahhl added a commit that referenced this issue Jan 6, 2022
badsgahhl added a commit that referenced this issue Jan 6, 2022
@badsgahhl badsgahhl linked a pull request Jan 6, 2022 that will close this issue
@badsgahhl
Copy link
Owner

Still broken. Now disabled is shown wrong -> pi-hole/web#2051 (comment)

@badsgahhl badsgahhl reopened this Jan 6, 2022
This was referenced Jan 6, 2022
badsgahhl added a commit that referenced this issue Jan 9, 2022
@badsgahhl
Copy link
Owner

3.0.2. now reverts the changes from 3.0.1.

Extension should be fixed alongside with a new PiHole version upcoming the next days.

@rezzorix
Copy link

Why not keeping the issue "open" as long as it is not fixed-> imp[lemented (means error gone for the users).
Otherwise you will get just more and more issues opened up here... I was about to, but checked out the closed issues...

@badsgahhl
Copy link
Owner

Good idea. The text on the main page is kinda invisible.

@badsgahhl badsgahhl reopened this Jan 11, 2022
@rezzorix
Copy link

Good idea. The text on the main page is kinda invisible.

Also the settings page -> trouble shooting of the extension directs you to the "issues page" here on github (at least for Firefox, dont know about other browsers).
So naturally people wont necessary see the indeed almost invisible note about the bug on main page 😉

@badsgahhl badsgahhl pinned this issue Jan 11, 2022
@badsgahhl badsgahhl changed the title latest pihole showing status == disabled Extension always displaying off (disabled) Jan 11, 2022
@eugef66
Copy link

eugef66 commented Jan 11, 2022

Same problem. Stopped working after pihole latest update

@joeroback
Copy link
Author

Same problem. Stopped working after pihole latest update

well nothing has changed, pi-hole hasn't yet released the fix, and the browser will forcefully update the extension 🤷🏼

@holocronology
Copy link

Also still seeing this issue.

PiHole Browser Extension: 3.0.2
Browser: Mozilla Firefox 96.0

@jkbdco
Copy link

jkbdco commented Jan 12, 2022

Same issue on both Firefox and Chrome:

PiHole Browser Extension: 3.0.2
Operating System: Linux x86_64
Browser: Mozilla Firefox 91.0

PiHole Browser Extension: 3.0.2
Operating System: Linux x86_64
Browser: Chrome/Chromium 96.0.4664.110

@eugef66
Copy link

eugef66 commented Jan 12, 2022

Yes the issue is known. Please be patient until PiHole releases a new version.

I didn't realize the issue is on PiHole end. It was not clear from this ticket. I was under impression that PiHole made some API changes and extension code need to be adjusted.

Anyways, will wait for a PiHole update and hope it will fix the problem.

@holocronology
Copy link

Same here...I didn't quite get that it was a pihole itself issue at first.

@fr4nk2342
Copy link

I don't know what they do differently, but maybe it helps.

The Android-App "Flutterhole" and the "Homeassistant Integration" are both working with the current PiHole version. Both are showing the correct status.

image

https://play.google.com/store/apps/details?id=sterrenburg.github.flutterhole&hl=gsw&gl=US
https://www.home-assistant.io/integrations/pi_hole/

@rezzorix
Copy link

I agree, weird that other apps work but the extension doesnt... maybe they have a work-around that the extension dev doesnt?

In any case, the bug is known and was fixed by the pihole team, mentioned here: pi-hole/web#2051 (comment)

It will be available to everyone with the next pihole update, which will be coming "soon" - see: pi-hole/web#2051 (comment)

So nothing else to do other than wait I guess...

@nagaden2
Copy link

Just sent you 10 euros for your troubles. Thanks!

@badsgahhl
Copy link
Owner

I don't know what they do differently, but maybe it helps.

The Android-App "Flutterhole" and the "Homeassistant Integration" are both working with the current PiHole version. Both are showing the correct status.

Don't use one of them. However, for instance Flutterhole also has an open issue about this bug.
sterrenb/flutterhole#158

Just sent you 10 euros for your troubles. Thanks!

Thanks for your support 🙌

@joeroback
Copy link
Author

it is quite annoying the pihole breaks the API with a regression for 2 weeks+ and doesn't do a hotfix if they are not ready for a full release... such is free and open source tho :)

@holocronology
Copy link

holocronology commented Jan 20, 2022

For those looking for a work around until this is fixed "soon" ... You can create a temporary bookmark with this process: https://discourse.pi-hole.net/t/is-there-an-api-command-to-disable-ad-blocking/7693/2

Alternatively, if you click the ON/OFF toggle in the extension to "ON" then click again to "OFF" it will still send the disable command to Pi-Hole and disable for your set time period. So basically it still functions, but you have to first force the extension to "ON" until the Pi-Hole bug fix is released.

@eugef66
Copy link

eugef66 commented Jan 20, 2022

I just did some testing on my PiHole and I don't see an issue with pihole api and now confused why extension is not working. In my case the "status" attribute correctly reflects current status of pihole, but extension is still showing "off"

image

image

image

image

image

@joeroback
Copy link
Author

please see pi-hole/web#2051

that changed the API call, previously it was api.php?status but currently its api.php which is a bug, because there is still code that wants to use status query parameter, but the code is broken, it just happens to work when you leave it off (by accident)

@eugef66
Copy link

eugef66 commented Jan 20, 2022

please see pi-hole/AdminLTE#2051

that changed the API call, previously it was api.php?status but currently its api.php which is a bug, because there is still code that wants to use status query parameter, but the code is broken, it just happens to work when you leave it off (by accident)

Ah-ha I see. Tested with a query parameter and I can confirm it returns "disabled", when pihole is active.

@stephan1827
Copy link

Is there any solution for this?

@badsgahhl
Copy link
Owner

Is there any solution for this?

Nope. We can only wait for the PiHole Update 🙃 Soon....

@christasich
Copy link

Is there any solution for this?

The fix has been merged into the development branch of pihole as noted here. You can check it out on your installation using pihole checkout web devel. If you run into any issues, you can always revert using pihole checkout master.

@rezzorix
Copy link

Still not fixed. Showing off/disabled even though it's definitely enabled. There is even a message on the extension settings saying that it is connected to the API

ps. I meant on the master. I did the web devel and pihole -up, it's working now. When can I revert back to master? Or is it safe to leave as web devel?

What is so difficult to understand that it is a bug in api.php that has been fixed by the pihole team already but will only be available with the next offical pihole update?

Again: the bug is on pihole (official) side, not with the extension.

In any case, the bug is known and was fixed by the pihole team, mentioned here: pi-hole/AdminLTE#2051 (comment)

It will be available to everyone with the next pihole update, which will be coming "soon" - see: pi-hole/AdminLTE#2051 (comment)

Ignoring facts & information that are widely available and then complaining about issues seems to be en vogue nowadays...

@badsgahhl
Copy link
Owner

Ok diva. Here's your chance to give another thumbs down so you can feel better!

Calling others a diva shows great maturity when you can't get it together to read comments.

@guice
Copy link

guice commented Feb 11, 2022

Ok diva. Here's your chance to give another thumbs down so you can feel better!

I’m going to defend @rezzorix here and point out you should have read the thread before commenting. It’s just common courtesy to get background on the issue before filing a complaint it wasn’t completed.

@eugef66
Copy link

eugef66 commented Feb 11, 2022

Ok diva. Here's your chance to give another thumbs down so you can feel better!

I’m going to defend @rezzorix here and point out you should have read the thread before commenting. It’s just common courtesy to get background on the issue before filing a complaint it wasn’t completed.

me too. Completely agree with above

@badsgahhl
Copy link
Owner

Fixed with https://github.com/pi-hole/AdminLTE/releases/tag/v5.11

@n3roGit
Copy link

n3roGit commented Apr 1, 2022

image
image

I have now switched to dev. unfortunately it still does not work :( Am I still doing something wrong?

@badsgahhl
Copy link
Owner

image image

I have now switched to dev. unfortunately it still does not work :( Am I still doing something wrong?

Normally it should just work with the latest PiHole version. No dev channel needed.

@n3roGit
Copy link

n3roGit commented Apr 4, 2022

No Its not working for me :(

@n3roGit
Copy link

n3roGit commented Apr 6, 2022

Any News?

@eugef66
Copy link

eugef66 commented Apr 6, 2022

Any News?

It’s working for everyone else after latest pi-hole upgrade. I’m sure it’s your local issue. Try re-installing extension and make sure pinhole is the latest version.

@n3roGit
Copy link

n3roGit commented Apr 6, 2022

I have done all this things

@n3roGit
Copy link

n3roGit commented Apr 27, 2022

Still not working with this version:
image
i dont know whats wrong.

It must be the plugin. If I address the API directly it works:

http://pihole.fritz.box/admin/api.php?disable&auth=xxxxxxx

@badsgahhl badsgahhl unpinned this issue Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

14 participants