Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft(task_either): tryCatch refactor #52

Closed
wants to merge 2 commits into from
Closed

draft(task_either): tryCatch refactor #52

wants to merge 2 commits into from

Conversation

pixeleet
Copy link
Collaborator

@pixeleet pixeleet commented Apr 2, 2022

We talked about a new way of dealing with tryCatch in #50
This is a draft / POC PR of what was discussed there, for easier discussion everything is easily testable from this PR.

@pixeleet
Copy link
Collaborator Author

pixeleet commented Apr 2, 2022 •
edited
Loading

The two things that come off weird to me after having it implemented and tested is:

  • we're no longer accepting Task as the ADT suggests.
  • passing arguments on to the error clause as we do (2nd argument as a spread), feels somewhat unnatural

Edit: realized quickly, I'm wrong on point 1.

@pixeleet pixeleet requested a review from baetheus April 2, 2022 10:57
@pixeleet pixeleet closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baetheus baetheus Awaiting requested review from baetheus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pixeleet