Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singleError fails with custom validators #19

Closed
planestepper opened this issue Jan 31, 2012 · 5 comments
Closed

singleError fails with custom validators #19

planestepper opened this issue Jan 31, 2012 · 5 comments

Comments

@planestepper
Copy link

Creating a schema and then calling the validate method with added custom validators while setting { singleError: false } on the method call returns no errors to the callback. Removing the { singleError: false } makes it work again. It seems the issue lies not on the value provided for singleError, as passing { singleError: true } also breaks the validation error returns. My tests have shown that, even though the error objects are not returned, the custom methods do run.

@planestepper
Copy link
Author

I've added #20 with the fix for the issue.

@Baggz
Copy link
Owner

Baggz commented Feb 1, 2012

Could you provide me with an example, please? I can't replicate this issue.

@planestepper
Copy link
Author

Does a coffee test work for you?

@Baggz
Copy link
Owner

Baggz commented Feb 2, 2012

Sure.

@planestepper
Copy link
Author

Hmm. My tests do not behave the same as my script does... so I guess the issue was between the keyboard and chair. If something else pops up I'll add it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants