Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution of fixpack in projects with spaces in the CWD #10

Merged
merged 2 commits into from
Apr 21, 2014

Conversation

creynders
Copy link
Contributor

Hi there,

Fixpack couldn't get executed in projects with spaces in the path, I fixed it by surrounding the path with double quotes.

I added an additional optimization: instead of executing node <...>/node_modules/fixpack/fixpack it's better to execute the bin file in node_modules/.bin directly. Obviously ATM this is the same thing since .bin/fixpack file is a symlink, but the advantage is that should fixpack change their directory structure (and dump the fixpack file in a lib dir for instance) then you won't have to update your code, otherwise you would.

However if you don't like the optimization, just cherry-pick the first commit to fix the execution in paths with spaces.

bahmutov added a commit that referenced this pull request Apr 21, 2014
Fix execution of fixpack in projects with spaces in the CWD
@bahmutov bahmutov merged commit 59b4202 into bahmutov:master Apr 21, 2014
@bahmutov
Copy link
Owner

Thanks for fixing this. It would be even nicer to be able to use fixpack as a module or at least grab the bin path from fixpack's package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants