Fix execution of fixpack in projects with spaces in the CWD #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Fixpack couldn't get executed in projects with spaces in the path, I fixed it by surrounding the path with double quotes.
I added an additional optimization: instead of executing
node <...>/node_modules/fixpack/fixpack
it's better to execute the bin file in node_modules/.bin directly. Obviously ATM this is the same thing since .bin/fixpack file is a symlink, but the advantage is that should fixpack change their directory structure (and dump the fixpack file in a lib dir for instance) then you won't have to update your code, otherwise you would.However if you don't like the optimization, just cherry-pick the first commit to fix the execution in paths with spaces.