Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around cache module modifying input paths #188

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

Bertg
Copy link
Contributor

@Bertg Bertg commented Aug 1, 2023

An issue in action/toolkit modifies the inputPath values passed to cache function. These changes work around this issue.

For more details see: actions/toolkit#1378

This resolves #175

An issue in action/toolkit modifies the inputPath values passed to cache function. These changes work around this issue.

For more details see: actions/toolkit#1378

Co-authored-by: Justin Leis <justin.leis@webewizard.com>
@Bertg Bertg mentioned this pull request Aug 1, 2023
Copy link
Owner

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very interesting, merging now

@bahmutov bahmutov merged commit fe55be8 into bahmutov:master Aug 1, 2023
17 checks passed
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

🎉 This PR is included in version 1.8.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oleksandr-danylchenko
Copy link

@Bertg, thank you so much!

@oleksandr-danylchenko
Copy link

Are there any dates on when the version bump in the GitHub Actions marketplace is planned for?
Seems like it's still using the 1.6.0 version, instead of the latest 1.8.33
image

@bahmutov
Copy link
Owner

bahmutov commented Aug 2, 2023

@oleksandr-danylchenko the version displayed on GitHub Actions marketplace does not matter, you still pick the version you want to use. I should find out if there is an automatic way to update the marketplace version

@oleksandr-danylchenko
Copy link

oleksandr-danylchenko commented Aug 2, 2023

Thanks 👌🏻
I manually picked the 1.8.33 version in the action. Just wondering about the marketplace to be able to use the latest version automatically just with @1

@Bertg
Copy link
Contributor Author

Bertg commented Aug 2, 2023

@oleksandr-danylchenko We use the @1 notion in our workflows. And we are seeing cache hits again. So I'm fairly certain it just works, and there is a disconnect between the marketplace displayed version, and the actual version resolution in the GitHub actions.

@Bertg
Copy link
Contributor Author

Bertg commented Aug 3, 2023

@bahmutov If you still are looking into the issue, as to why the version in marketplace is lagging, here are the docs: https://docs.github.com/en/actions/creating-actions/publishing-actions-in-github-marketplace

It may have something to do with accepting the "GitHub Marketplace Developer Agreement", which is something that is new to me, and maybe to you as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"npm cache hit undefined"
3 participants