Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bin): added --harmony option wrapper scripts(cross-platform) #72

Merged
merged 1 commit into from
Mar 16, 2016
Merged

fix(bin): added --harmony option wrapper scripts(cross-platform) #72

merged 1 commit into from
Mar 16, 2016

Conversation

ybiquitous
Copy link
Collaborator

Windows and Linux is tested, but Mac is not.

maybe will fixes #68

Windows and Linux is tested, but Mac is not.

maybe will fixes #68
@ybiquitous
Copy link
Collaborator Author

In view of the DRY principle, each wrapper script call _readlink_f function in helper script _pre-git-helpers.
Underscore (_) prefix means private script (not intended to be called directly.).

@bahmutov
Copy link
Owner

Ok, merging, will release as a bug fix soon

bahmutov added a commit that referenced this pull request Mar 16, 2016
fix(bin): added --harmony option wrapper scripts(cross-platform)
@bahmutov bahmutov merged commit ad27096 into bahmutov:master Mar 16, 2016
@bahmutov
Copy link
Owner

ok, 3.6.1 is out, test it on windows?

@bahmutov
Copy link
Owner

seems to work on Mac!

@ybiquitous
Copy link
Collaborator Author

Thanks, v3.6.1 works also on Windows 😄

  • Git Bash (Git for Windows): work fine!
  • Command prompt: work if sh.exe in PATH (e.g. set PATH=C:\Program Files\Git\bin;%PATH%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script error on Git Bash (Windows)
2 participants