Simplify VectorTileFeature.decodeProperties #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of decoding each property to a separate map, decode to a single map. This reduces Map allocations, and means that properties can be resolved with a simple map lookup rather than iterating through a list of maps and attempting a lookup in each one. This improvement reduces memory usage and makes property lookup more efficient.
|
Nice catch! This is my mistake, I don't remember the reason why I created a Map for each property. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of decoding each property to a separate
map, decode to a single map. This reduces Map
allocations, and means that properties can be
resolved with a simple map lookup rather than
iterating through a list of maps and attempting
a lookup in each one.
This improvement reduces memory usage and
makes property lookup more efficient.