feat: icon组件兼容sdk下使用svg object的情况 #8602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for this! Please review the labels and make any necessary changes. |
2betop
approved these changes
Nov 2, 2023
allenve
approved these changes
Nov 2, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| // 直接传入svg字符串 | ||
| if (typeof icon === 'string' && icon.startsWith('<svg')) { | ||
| return <i dangerouslySetInnerHTML={{__html: icon}} />; | ||
| const svgStr = /<svg .*?>(.*?)<\/svg>/.exec(icon); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
🤖 Generated by Copilot at 69f0826
Fixed icon rendering issues and improved import efficiency in
icons.tsx. Added support for custom svg icons in icon schema.🤖 Generated by Copilot at 69f0826
Why
How
🤖 Generated by Copilot at 69f0826
createElementfromreact(link)