Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复列过滤选择与实际展示不一致问题 #8647

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

2betop
Copy link
Collaborator

@2betop 2betop commented Nov 7, 2023

What

🤖 Generated by Copilot at 1c0415c

This pull request enhances the auto filter feature of the table renderer in amis, a low-code framework for building admin interfaces. It fixes a bug, improves the UI, and refactors some code in AutoFilterForm.tsx and adds a new SCSS class in _table.scss for the auto filter toolbar.

🤖 Generated by Copilot at 1c0415c

To render a table with flair
We added a toolbar with care
It has auto-filter
And an expander fixer
And some SCSS class for its hair

Why

How

🤖 Generated by Copilot at 1c0415c

  • Fix a bug in the auto filter toolbar that showed the expander button when all searchable columns were hidden or disabled (link)
  • Add a new SCSS class for the auto filter toolbar and apply it to the button container (link, link)
  • Refactor the rendering of the checkbox components for the auto filter form using a children function (link)
  • Adjust the styles and spacing of the submit and reset buttons for the auto filter form (link)
  • Improve the user experience of the auto filter form by only expanding it when a column is toggled on for search (link)

@github-actions github-actions bot added the fix label Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.

Please review the labels and make any necessary changes.

@hsm-lv hsm-lv merged commit a9eafda into baidu:master Nov 7, 2023
5 checks passed
@2betop 2betop deleted the fix-autofilterform branch January 17, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants