Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amis-editor): addChild新增reGenerateId参数控制，并优化reGenerateID逻辑 #9248

Merged
merged 3 commits into from
Dec 28, 2023
Merged

fix(amis-editor): addChild新增reGenerateId参数控制，并优化reGenerateID逻辑 #9248

merged 3 commits into from
Dec 28, 2023

Conversation

wibetter
Copy link
Collaborator

@wibetter wibetter commented Dec 26, 2023 •
edited
Loading

  1. addChild新增reGenerateId参数控制，可用于控制不重置组件id；
  2. 优化reGenerateID逻辑：遍历到某个节点时还需考虑未遍历到的节点，避免事件动作（onEvent中的componentId没有正常替换）失效。

@github-actions github-actions bot added the fix label Dec 26, 2023
@github-actions GitHub Actions
Copy link

👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.

Please review the labels and make any necessary changes.

@wibetter
Copy link
Collaborator Author

还有一种场景没有兼顾到：当前页面中元素的复制和粘贴。reGenerateID中把componentId重置了，但对应的组件id可能没被重置（页面其他组件，非当前插入json中）。

@wibetter wibetter merged commit d2f5fc2 into baidu:master Dec 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangtao07 zhangtao07 zhangtao07 approved these changes

@yangwei9012 yangwei9012 yangwei9012 approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wibetter @zhangtao07 @yangwei9012