Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control high priority block num when pick recover blocks #212

Closed
wants to merge 1 commit into from

Conversation

yvxiang
Copy link
Collaborator

@yvxiang yvxiang commented Feb 15, 2016

#201

设置两个不同的watermark以及一个threshold
当所有high priority的block数超threshold时,对每个cs,让其尽量多的选择high priority block,但是不能超过high watermark
当所有high priority的block数低于threshold时,尽量让这些block分散,不过,仍保持每个cs上的数目不低于low watermark
当确定了high priority的数目后,剩余的quota分配给low priority的block

@yvxiang yvxiang mentioned this pull request Feb 15, 2016
@lylei
Copy link
Collaborator

lylei commented Feb 15, 2016

这个解决的是所有hi都扔到一台cs上的问题么?直接平均分配有什么问题么?

@yvxiang
Copy link
Collaborator Author

yvxiang commented Feb 15, 2016

如果直接将剩余的hi平均分配,那么有可能某个cs上的hi过多(因为其正在进行的hi可能就比较多),然而单个cs的能力是有限的,不见得能体现出hi的重要程度,如果将所有的hi(剩余+正在进行的)平均分配,在hi较多时,每台cs pick的数目平均下来较少,则不能尽快的将其处理完。于是搞了两个watermark

@yvxiang
Copy link
Collaborator Author

yvxiang commented Jul 4, 2016

分别控制hi low的个数还有必要么。。

@yvxiang yvxiang closed this Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants