Add lock #490
Merged
Add lock #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluebore
approved these changes
Sep 25, 2016
yvxiang
commented
Sep 25, 2016
| recover_speed += cs->recover_speed(); | ||
| if (cs->load() > kChunkServerLoadMax) { | ||
| ++overload; | ||
| } | ||
| } | ||
| } | ||
| stats_.w_qps = w_qps; |
There was a problem hiding this comment.
这里有必要锁么？读的时候是没加锁的，整数读/写也应该是原子的，最多导致读出来的stats_结构里多个数据间不一致
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个一秒一次，不知道会不会有点费