Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: renderOnly should backward compatible with old version #167

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: renderOnly should backward compatible with old version #167

merged 1 commit into from
May 31, 2023

Conversation

meixg
Copy link
Collaborator

@meixg meixg commented May 31, 2023

change

let data = info.renderOnly ? ctx.data : info.rootOutputData || ctx.data

to

let data = info.renderOnly ? ctx.data : info.rootOutputData || _.getRootCtx(ctx).data

The ctx.data part should only use on the root component.

But, when some components are compiled with 3.13.0, and other components are compiled with older versions, there will be no info.rootOutputData in older components.

@meixg meixg merged commit a989bb4 into master May 31, 2023
@meixg meixg deleted the render-only-backward-compatible branch May 31, 2023 12:09
github-actions bot pushed a commit that referenced this pull request May 31, 2023
@semantic-release-bot
chore(release): 3.13.1 [skip ci]
fdaff53 
## [3.13.1](nv3.13.0...nv3.13.1) (2023-05-31)

### Bug Fixes

* renderOnly should backward compatible with old version ([#167](#167)) ([a989bb4](a989bb4))
@github-actions
Copy link

🎉 This PR is included in version 3.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@meixg