issue=#1030 bugfix of multi-load at master initial phase #1038
Conversation
| VLOG(8) << "OFFLINE Tablet with empty addr, " << tablet; | ||
| } else if (!tabletnode_manager_->FindTabletNode(server_addr, &node)) { | ||
| tablet->SetStatus(kTableOffLine); | ||
| VLOG(8) << "OFFLINE Tablet of Dead TS, " << tablet; |
There was a problem hiding this comment.
是否应该用应该判断是否是not init状态，在考虑设置offline；有可能ts被kick；
There was a problem hiding this comment.
@caijieming-baidu 上面几行已经check过啦，请看395行
There was a problem hiding this comment.
我的意思是上面的check init 到set offline之间，是有机制保证肯定不会发生状态转换吗？
There was a problem hiding this comment.
有保证，这个函数执行的时候是初始化阶段，还不会有其它线程去操作tablet，唯一的例外是zk的触发事件，这是通过tabletnode_mutex_去保证的
| VLOG(8) << "OFFLINE Tablet of Dead TS, " << tablet; | ||
| } else if (node->state_ == kReady) { | ||
| tablet->SetStatus(kTableOffLine); | ||
| VLOG(8) << "OFFLINE Tablet of Alive TS, " << tablet; | ||
| TryLoadTablet(tablet, server_addr); |
| dead_node_tablet_list.push_back(tablet); | ||
| // Ts not response, we count its tablets as Ready and wait for it to be kicked. | ||
| tablet->SetStatus(kTableReady); | ||
| VLOG(8) << "UNKNOWN Tablet of No-Response TS, " << tablet; |
There was a problem hiding this comment.
ts被kick的事件，并不会对处于init状态的tablet进行出来，此时将tablet设置成ready，是否会造成tablet游离，无人管理。
There was a problem hiding this comment.
@caijieming-baidu 这个函数在入口拿了tabletnode_mutex_锁，与DeleteTabletNode/AddTabletNode是同一把锁，会保证ts被kick等情况的处理变成串行的，所以不会有问题
| uint32_t meta_num = response->tabletmeta_list().meta_size(); | ||
| for (uint32_t i = 0; i < meta_num; i++) { |
There was a problem hiding this comment.
some tablets may load on such new ts
There was a problem hiding this comment.
@caijieming-baidu We have to assume the new ts has no tablet loaded, otherwise ‘multi-load’ would be inevitable.
This is the fundamental design of Tera.
There was a problem hiding this comment.
if new ts has no tablet, why query it?
There was a problem hiding this comment.
to make sure this TS is alive and switch its status to kReady
There was a problem hiding this comment.
zk/nexus notifies master that a new ts restart, so we no need to query it.
There was a problem hiding this comment.
Good point. Do you mind if I remove the query logic and call this function within AddTabletNode?
|
LGTM |
#1030