Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standard setters for com.baidu.acu.pie.model.AsrConfig #56

Closed
wanglihaoo opened this issue May 6, 2019 · 0 comments
Closed

standard setters for com.baidu.acu.pie.model.AsrConfig #56

wanglihaoo opened this issue May 6, 2019 · 0 comments

Comments

@wanglihaoo
Copy link
Contributor

The comment in AsrConfig says it will not provide setters, but actually AsrConfig has methods that can modify its fields.

If modifier is allowed, why not provide standard setters (setXXX)? If standard setters provided,
this class becomes a POJO then can be used more conveniently.
cynricshu added a commit that referenced this issue May 9, 2019
@cynricshu
Merge pull request #62 from baidubce/java-1.0.0
71cc913 
[java] refatcot: simplify code (close #56)
@wanglihaoo wanglihaoo mentioned this issue May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wanglihaoo