Add jib-uploader action #175
Conversation
irux
requested review from
yannick-roeder,
MichaelKora and
yordanovsstoyan
as code owners
actions/jib-uploader/action.yaml
Outdated
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Build Docker image |
There was a problem hiding this comment.
| - name: Build Docker image | |
| - name: Build & push Docker image |
actions/jib-uploader/action.yaml
Outdated
| description: "The entrypoint class to be used for the image" | ||
| required: true | ||
| working-directory: | ||
| description: "working directory to run the commands" |
There was a problem hiding this comment.
| description: "working directory to run the commands" | |
| description: "Working directory to run the commands" |
actions/jib-uploader/action.yaml
Outdated
| ./gradlew jib \ | ||
| --info --stacktrace \ | ||
| --image=${{ inputs.image }} \ | ||
| -Djib.container.mainClass=${{ inputs.class }} \ |
There was a problem hiding this comment.
Is this really needs to be required?
It think the user can configure this in its own application.
There was a problem hiding this comment.
I am not sure to be honest, should I remove it ?
There was a problem hiding this comment.
This can definitely be set in the build.gradle file of the specific project as well, so yes please remove it here
There was a problem hiding this comment.
should we still support it as an optional feature or should we remove it completely? what do you guys think ?
There was a problem hiding this comment.
I would have it removed. The user should take of the mainClass 🙂
There was a problem hiding this comment.
We could make it optional as well if there are multiple jib images to be built with different main classes. But I don't have such a use case so I would be fine with removing it
There was a problem hiding this comment.
@philipp94831 following up this. But how would it work when you have multiple entry points in every module of your project ? do we have such thing atm ? or it is not something it happens quite often ? if not, then I would just remove it.
There was a problem hiding this comment.
User needs to configure mainClass in gradle file
There was a problem hiding this comment.
Ok then I will remove it
actions/jib-uploader/action.yaml
Outdated
There was a problem hiding this comment.
What do you think about java-gradle-build-push-jib as the action name, so that it can easier be found when looking for Java Gradle actions?
| required: true | ||
| class: | ||
| description: "The entrypoint class to be used for the image" | ||
| required: true |
There was a problem hiding this comment.
Please make this optional. We often times define it in the build.gradle file
|
@irux A corresponding action has already been merged now and I think this PR can be closed: https://github.com/bakdata/ci-templates/blob/main/actions/java-gradle-build-jib/action.yaml |
No description provided.