Allow configurable timeouts and simplify local maven publishing #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torbsto
commented
Feb 4, 2021
| this.allTasks.filter { it is Sign }.forEach { | ||
| // disable sign for publishToLocalMaven | ||
| it.onlyIf { !onlyLocalPublish } |
There was a problem hiding this comment.
This disables all sign tasks if we only do a publishToLocalMaven. Is there anything against it?
There was a problem hiding this comment.
Very nice, publishing to local is very helpful
Comment on lines
+30
to
+31
| var connectTimeout: Long = 300 | ||
| var clientTimeout: Long = 300 |
There was a problem hiding this comment.
I set the defaults to 5m, might be a bit high? I didn't find any suggested defaults, the publishing plugin uses 60s, but I think we already had trouble with that, right?
There was a problem hiding this comment.
5m sounds reasonable, 60s is definitely too low
philipp94831
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
Also disables singing and property checking for local maven releases.