Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whiteflash workaround (tested in firefox) #172

Closed
martinpospech opened this issue Jan 4, 2021 · 7 comments
Closed

whiteflash workaround (tested in firefox) #172

martinpospech opened this issue Jan 4, 2021 · 7 comments
Assignees

Comments

@martinpospech
Copy link

martinpospech commented Jan 4, 2021

If you only use the dark theme you can add the following to your ublock filters:

! 2021-01-04 https://better-call.dev
better-call.dev##body:style(background-color: #2d2d2d)

repro

  1. https://better-call.dev/delphinet/KT1Ewcq3ZLKQ2gDP1QTkWYxe7DiKYFKqtX5E/code
  2. press home & end buttons

An actual fix has to be done in the source itself to work with the white theme etc.

@m-kus m-kus self-assigned this Jan 7, 2021
@martinpospech
Copy link
Author

The above is about the whiteflash in the main area (doesn't occur in the left bar).

There's another separate full viewport white flash (let's call it whiteflash no. 2), triggered on page loads.

Repro:

  1. go to contract details page (probably occurs everywhere, but I tested on contract details)
  2. set CPU governor to powersave to trigger the whiteflash more reliably
  3. reload with F5 5 or 10 times until it happens

@martinpospech
Copy link
Author

martinpospech commented Jan 8, 2021

Whiteflash no. 3 happens when navigating to another contract from a contract inspection modal ("View"). If the button is a simple HTML anchor link instead, the flash doesn't happen. (Tested by editing DOM via browser devtools.)

Screenshot_20210108_234746

Everything tested in Firefox with dark theme & hardware acceleration off.

@m-kus m-kus assigned ungarson and unassigned m-kus Jan 9, 2021
@ungarson
Copy link
Contributor

Thanks. Working on it right now.

@ungarson
Copy link
Contributor

PR to resolve this problem: #182

@ungarson
Copy link
Contributor

@m-kus we can close it, I guess?

@m-kus
Copy link
Member

m-kus commented Jan 24, 2021

Yep, as soon as 3.3 is released to prod

@ungarson
Copy link
Contributor

@martinpospech fixed 😎🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants