Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting pytezos.crypto into a separate pip package #284

Closed
elric1 opened this issue Feb 8, 2022 · 9 comments
Closed

Consider splitting pytezos.crypto into a separate pip package #284

elric1 opened this issue Feb 8, 2022 · 9 comments
Assignees
Labels
🚢 ci/cd Dockerfiles, GitHub Actions and stuff like that 👋 community Reported or suggested by our awesome users

Comments

@elric1
Copy link

elric1 commented Feb 8, 2022

The smaller package would be of use in at least two projects with which I am involved to reduce the size of our generated docker images.

@aliel
Copy link

aliel commented Jul 6, 2022

Up

@hoh
Copy link

hoh commented Jul 6, 2022

Installing Pytezos currently requires approximately 141 MB of dependencies, including Jupyter and other libraries that are not useful for checking signature and other cryptographic operations.

@droserasprout
Copy link
Member

Hi, thanks for bumping this!

Merging the Jupyter kernel into the main repo helped us to establish a single release cycle between those. I think it's the right time to go further and split something like the pytezos-core package out of the main repo.

Do you think pytezos.crypto will be sufficient? May forging/unforging or RPC wrappers also come in handy?

@elric1
Copy link
Author

elric1 commented Jul 7, 2022

For my purposes, pytezos.crypto is sufficient.

@droserasprout droserasprout self-assigned this Jul 7, 2022
@droserasprout droserasprout added the enhancement New feature or request label Jul 7, 2022
@hoh
Copy link

hoh commented Aug 1, 2022

pytezos.crypto would also be sufficient for my usecases.

@aliel
Copy link

aliel commented Sep 7, 2022

Hello,
we forked the crypto part available here => https://github.com/aleph-im/aleph-pytezos

@droserasprout
Copy link
Member

Sorry about the delay. I'm still unsure about how to implement this one since Poetry - a tool we use for packaging - has no native monorepo support—going to figure it out in the next few days.

@droserasprout droserasprout added this to the 3.7.0 milestone Sep 7, 2022
@droserasprout

This comment was marked as outdated.

@droserasprout droserasprout added 👋 community Reported or suggested by our awesome users 🚢 ci/cd Dockerfiles, GitHub Actions and stuff like that and removed enhancement New feature or request labels Sep 14, 2022
@m-kus m-kus removed this from the 3.7.0 milestone Sep 19, 2022
@droserasprout
Copy link
Member

After some consideration we decided that maintaining a separate package would be too time consuming despite being technically possible. Our latest Docker image is 122MB uncompressed, which isn't perfect, but, well, competitive I think. Closing this issue as wontdo.

Please, don't use pytezos-core 1.0.0rc1 prerelease image and Python package as they are very outdated.

@droserasprout droserasprout closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚢 ci/cd Dockerfiles, GitHub Actions and stuff like that 👋 community Reported or suggested by our awesome users
Projects
None yet
Development

No branches or pull requests

5 participants