-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong xsessions directory in Makefile #317
Comments
Yes but no but yes but no but yes but no but yes I agree on all points.
That is indeed a typo.
True. I have also noticed that the bspwm guys install their .desktop file under As for the difference between
Then we have:
I like the general idea. So with dwm.desktop in In the unlikely scenario that you have more than one people using dwm and sharing the same machine then they can run their separate builds of the window manager as needed. I presume that for the |
I am wondering if it should it be Proposed change: diff --git a/Makefile b/Makefile
index 01ea136..f309ae0 100644
--- a/Makefile
+++ b/Makefile
@@ -65,13 +65,13 @@ endif
mkdir -p ${DESTDIR}${MANPREFIX}/man1
sed "s/VERSION/${VERSION}/g" < dwm.1 > ${DESTDIR}${MANPREFIX}/man1/dwm.1
chmod 644 ${DESTDIR}${MANPREFIX}/man1/dwm.1
- mkdir -p ${DESTDIR}${PREFIX}/share/xsession
- cp -n dwm.desktop ${DESTDIR}${PREFIX}/share/xsession
- chmod 644 ${DESTDIR}${PREFIX}/share/xsession/dwm.desktop
+ mkdir -p /usr/share/xsessions
+ cp -n dwm.desktop /usr/share/xsessions
+ chmod 644 /usr/share/xsessions/dwm.desktop
uninstall:
rm -f ${DESTDIR}${PREFIX}/bin/dwm\
${DESTDIR}${MANPREFIX}/man1/dwm.1\
- ${DESTDIR}${PREFIX}/share/xsession/dwm.desktop
+ /usr/share/xsessions/dwm.desktop
.PHONY: all options clean dist install uninstall |
Thank you for your reply!
Maybe the xsessions directory should be a variable inside
That was exactly my reasoning. Honestly, I don't think such a scenario would happen any time soon, but I thought it would be good practice to keep everything I use inside ~.
That is the approach I am trying to use. I just added the sudo calls inside the Makefile.
Personally, I think the default path should be
Would it be bad if you added the |
All the yes bot no thing make me crazy :P |
I think the above should solve this, let me know if you spot any problems. |
I'll try out that change in makefile on the weekend and paste it here my results. By the way, congratulations with that project. I tried out a lot of WM, but Dwm is the best for my weak machine. |
Using
Hardcoding the path also breaks some distributions such as NixOS. I am not sure how users of that distribution get around it, but since the PREFIX and DESTDIR variables are common I'd imagine they override that somewhere. I would suggest reverting the commit, but fixing the path. |
@speediegq thanks for the feedback.
I agree. Overall this seems to be the simplest approach. For people that are specifically interested in user specific installation of dwm I think it would be better to accompany that with a How To discussion page outlining what would need changing in |
…gested in bakkeby#317" This reverts commit f0ad111.
I believe there is a typo in the Makefile when copying
dwm.desktop
to the xsessions directory.As stated in the ArchWiki, the default xsessions directory is
/usr/share/xsessions
, but the current Makefile copies dwm.desktop to${DESTDIR}${PREFIX}/share/xsession
(there is as
missing at the end).Furthermore, I think it would be benefitial if the destination directory wasn't defined by the
DESTDIR
andPREFIX
variables. Personally, I change thePREFIX
insideconfig.mk
to~/.local
, in order to install dwm locally. But, by doing so, the default xsessions directory ends up empty.The text was updated successfully, but these errors were encountered: