-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with python <= 2.6 #1
Comments
empty formatting is used a lot (things like "{}/{}".format(val1, val2) instead of "{0}/{1}".format(...)) I ended up moving to 2.7 but in platforms where 2.6 is the default (like OSX) it's a bit annoying. |
Yeah, that's one issue I'm aware of. |
The other issue is that since identifiers can't be unicode in Python 2.x, you can't unpack keyword arguments with unicode string keys (in 2.7 this limitation was removed on the unpacking side, but you still can't have unicode identifiers): You're using simplejson for unpacking the json responses, and it always turns strings to unicode (This is done in the Page object for example). A work around would be to create a dict where you call str() on all the keys whenever you're unpacking deserialized json into a function call (I have a version where I implemented this fix locally, but I ended up upgrading to Python 2.7 since that's what heroku provides and my client uses). Please note that a lot of environments still provide only 2.6 (for example, that's what you get by default on AWS), so I would recommend supporting it. |
We've got a python2.6 branch which will solve this. It's on the way. |
Thanks! On Wed, Jul 18, 2012 at 6:44 PM, Marshall Jones <
|
Do we want to merge this into master? The differences are just string formatting and losing some of the nice helpers that we get in the 2.7 test library. Failing to do so requires us to keep 2 separate branches up to date. |
The text was updated successfully, but these errors were encountered: