-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dataQueries with multicallV3 (with batching) #101
Conversation
…Queries ABI. Update onChainPoolDataEnricher. Removed queryFailed as not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean implementation 👏 LGTM 👍
'0xac4b72c01072a52b73ca71105504f1372efcce0d000000000000000000000003', | ||
'0xbfd65c6160cfd638a85c645e6e6d8acac5dac935000000000000000000000004', | ||
'0xe274c9deb6ed34cfe4130f8d0a8a948dea5bb28600000000000000000000000d', | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way to filter them out in the subgraph, or RPC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These get used in the Subgraph provider query to filter. Or do you mean by default at source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, at source, since we know the pool is bricked, we could set a flag somewhere that it's killed, is there something like that on a contract?
Fantom config
…emove multicallV3 abi, etc.
Replace dataQueries:
Add MulticallV3:
fetchAdditionalPoolData
only makes working calls to existing pools (reduces call amount)Other: