fix: Ignore throwing paths #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmbronco
force-pushed
the
fix/ignore-throwing-path
branch
from
111bfe1
to
858e739
Compare
brunoguerios
approved these changes
Dec 11, 2023
gmbronco
force-pushed
the
fix/ignore-throwing-path
branch
from
858e739
to
b97bff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing multiple paths for a swap, if one pool in any path is throwing, eg: new Error('Swap amount exceeds the pool limit') - it makes the PathGraph.getCandidatePaths to fail for all the other paths. Handling the error allows to return the other paths.