V3 BatchSwaps #263
Merged
V3 BatchSwaps #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
brunoguerios
requested changes
Mar 21, 2024
…d in both to reuse as much common code as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest change is how we create call for V3 batchSwaps. Each independent path in
swapExactIn/Outneeds to have itsminAmountOut/maxAmountInset correctly using the user defined slippage (compared to V2 where we just updated a single limit index). Discussed with Daniel/Juani and we belive the Router swap queries (not curently implemented) will be able to return the updated path amounts. These can then be used with user definied slippage to update the relevant paths during call build.