Add GyroEV2 pool #71
Merged
Add GyroEV2 pool #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johngrantuk
reviewed
Jun 23, 2023
There was a problem hiding this comment.
I think the onChainPoolDataEnricher needs to be updated to get the GyroE V2 tokenRates?
The current poolDataQuery helper doesn't support that. Could be done using a separate mulitcall like this. It would be more convenient if we updated the poolDataQuery helper but not sure if that's a reasonable approach?
…oken-rates # Conflicts: # test/gyroEV2Pool.integration.test.ts
Add token rates to pool enricher using multicall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
POLYGON_RPC_URLas env var (and it should also be added to github secrets in order to have PR checks working as expected)