New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Add/Remove Liquidity Nested #99

Merged

brunoguerios merged 92 commits into main from nested-join

Jan 17, 2024

Member

brunoguerios commented Sep 27, 2023 •

edited

Loading

Done:

AddLiquidityNested
AddLiquidityNested with native asset
RemoveLiquidityNestedProportional
RemoveLiquidityNestedProportional with native asset
RemoveLiquidityNestedSingleToken
RemoveLiquidityNestedSingleToken with native asset

Pending:

Examples
Update readme

Notes:

relies on locally deployed relayer, so github checks will fail until we add these steps to the flow or SC deploys the new relayer version to mainnet

brunoguerios added 5 commits

September 22, 2023 16:53


          Initial draft with hardcoded values to focus on lower level methods (…

…wip)


          Grant proper roles to relayer deployed locally

4e046fd


          Fix relayer approval signature within multicall

74268bc


          First working version of nested-joins

aeaf966


          Merge remote-tracking branch 'origin/fix-circular-deps' into nested-join

d2081da

brunoguerios requested review from johngrantuk and danielmkm

September 27, 2023 14:49

brunoguerios self-assigned this


          Minor refactors

f0edb4a

Base automatically changed from fix-circular-deps to join

September 28, 2023 08:25

johngrantuk reviewed

View reviewed changes

src/entities/encoders/stable.ts Outdated Show resolved Hide resolved

johngrantuk reviewed

View reviewed changes

src/entities/encoders/stable.ts Outdated Show resolved Hide resolved

johngrantuk reviewed

View reviewed changes

src/utils/constants.ts Outdated Show resolved Hide resolved

johngrantuk reviewed

View reviewed changes

src/entities/nestedJoin/index.ts Outdated Show resolved Hide resolved

johngrantuk reviewed

View reviewed changes

src/entities/nestedJoin/index.ts Outdated Show resolved Hide resolved

johngrantuk reviewed

View reviewed changes

src/entities/nestedJoin/index.ts Outdated Show resolved Hide resolved

johngrantuk reviewed

View reviewed changes

src/entities/nestedJoin/index.ts Outdated Show resolved Hide resolved

brunoguerios added 9 commits

September 28, 2023 09:55


          Remove unused comment


          Add ComposableStableEncoder

af4e5c2


          Update BALANCER_RELAYER constant to be per chain


          Move level from token to pool data

034fa83


          Refactor nested pool data structure

cfda997


          Add test case for all tokens join

0a7aeaf


          Add native asset nested join

1aed248


          Refactor methods to improve code readability

b64e29a


          Fix address comparison

61ae94f

brunoguerios marked this pull request as ready for review

October 9, 2023 20:44

brunoguerios requested a review from johngrantuk

October 9, 2023 20:44

brunoguerios added 2 commits

October 11, 2023 15:16


          Add changeset

584914b


          Minor refactors

4e64197

brunoguerios added 2 commits

November 10, 2023 10:06


          Merge remote-tracking branch 'origin/join' into nested-join

54e6c84

# Conflicts:
#	src/entities/encoders/composableStable.ts
#	test/anvil/anvil-global-setup.ts
#	test/lib/utils/helper.ts


          Remove commented out workaround

9afc5bb

Base automatically changed from join to main

November 14, 2023 18:03


          Merge remote-tracking branch 'origin/main' into nested-join

fb8f4cf

# Conflicts:
#	src/entities/index.ts

brunoguerios changed the title ~~Add Nested Join/Exit~~ Add Add/Remove Liquidity Nested

brunoguerios added 6 commits

November 16, 2023 11:21


          Refactor nested join into add liquidity nested

b9b4953


          Refactor nested exit into remove liquidity nested

639b13f


          Merge remote-tracking branch 'origin/main' into nested-join

ec774b2


          Hardcode token slots to improve test performance

3497b56


          Update blockNumber to avoid moving to an archived RPC url

39bcd43


          Skip nested liquidity integration tests (until relayerV6 is working a…

ed0f7ab

…s expected)

brunoguerios added this to the Add/Remove Liquidity Nested milestone

brunoguerios and others added 14 commits

January 10, 2024 16:38


          Merge remote-tracking branch 'origin/main' into nested-join

2bd8639

# Conflicts:
#	package.json
#	src/abi/index.ts
#	src/entities/index.ts
#	src/entities/types.ts
#	test/anvil/anvil-global-setup.ts
#	test/lib/utils/addLiquidityHelper.ts
#	test/lib/utils/removeLiquidityHelper.ts
#	test/v2/addLiquidity/gyroE.integration.test.ts


          Update relayer address to v6

310aa55


          Make biome the default formatter

ef5769c


          Fix lint issues

29491e4


          Allow custom blockNumber setup for PriceImpact tests

14624d2


          Fix blockNumber to match hardcoded comparison results

3ea99bd


          Reverted hardcoded comparison values

eced858


          Merge remote-tracking branch 'origin/main' into nested-join

fd97739

# Conflicts:
#	src/abi/index.ts


          chore: fix COMPOSABLE_STABLE api breaking change

6e90721


          Merge pull request #201 from balancer/nested-join-composable-stable

042c1ac

chore: fix COMPOSABLE_STABLE api breaking change


          Fix add liquidity nested example

6a4ce99


          Expose nested liquidity types

ac574bb


          Merge remote-tracking branch 'origin/main' into nested-join


          Update to work with viem v2

ef5c88d

brunoguerios marked this pull request as ready for review

January 17, 2024 17:24


          Improve pool type mapper safety by checking for unsupported types

47f952b

brunoguerios merged commit 3da18db into main

4 checks passed

brunoguerios deleted the nested-join branch

January 17, 2024 18:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet