Authorizer: Migration script #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Mar 18, 2022
pkg/deployments/tasks/2022xxxx-timelock-authorizer/test/task.fork.ts
Outdated
Show resolved
Hide resolved
facuspagnuolo
force-pushed
the
authorizer/renames
branch
from
1656944
to
5205c68
Compare
facuspagnuolo
force-pushed
the
authorizer/migration_script
branch
from
9ceb32b
to
addcf9e
Compare
facuspagnuolo
changed the base branch from
master
to
authorizer/improve_grant_revoken_granularity
Base automatically changed from
authorizer/improve_grant_revoken_granularity
to
master
April 4, 2022 20:09
facuspagnuolo
force-pushed
the
authorizer/migration_script
branch
from
eb97ed7
to
df27415
Compare
nventuro
reviewed
Apr 5, 2022
There was a problem hiding this comment.
Looks great! I think the only thing missing are some partial migration unit tests (i.e. migrate(n) with n != 0). To reduce duplication, I'd consider removing unit tests that also show up in the fork tests (see https://github.com/balancer-labs/balancer-v2-monorepo/pull/1173/files#r830266852).
Done!
It's not harmful since fork tests do not run on the CI |
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
nventuro
approved these changes
Apr 6, 2022
TomAFrench
added a commit
that referenced
this pull request
Apr 7, 2022
* master: (39 commits) Authorizer: Migration script (#1173) Managed Pool: BPT management fees (#1163) Improve token checkpointing logic (#1217) Prevent late lockers from having to claim many weeks of zero-value distributions (#1218) fix: make sure to use EVM time when calculating startTime (#1221) Add custom implementation of FeeDistributor contract (#1191) Authorizer: Improve grant/revoke delays granularity (#1197) Linear Pool: ERC4626 Finalized (#1177) Weighted pool: use correct compare operators (#1209) Re-do Polygon BalancerHelpers deployment Update deployments readme chore: deploy SmartWalletChecker to kovan (#1208) Add SmartWalletChecker (#1207) Update readme.md (#1206) veBAL deployment (#1205) Misc veBAL changes (#1204) chore: organise contracts in liquidity-mining package (#1203) Fix compile error Deploy Batch Relayer V2 to Polygon (#1182) Fix reading historical balances/total supply by timestamp (#1201) ...
dandamiangow3t
pushed a commit
to IlluviumGame/balancer-v2-monorepo
that referenced
this pull request
May 10, 2023
* authorizer: prepare migration script * authorizer: fix fork test * authorizer: fix fork test * authorizer: update migration with latest model changes * authorizer: delay root change * authorizer: test partial migrations * authorizer: fix linter * authorizer: improve deployment input layout Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERGE AFTER #1197
Fixes #1160