Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make calcAdjustedBound external #1930

Merged
merged 13 commits into from
Oct 20, 2022
Merged

Make calcAdjustedBound external #1930

merged 13 commits into from
Oct 20, 2022

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Oct 20, 2022

Split pow out of CircuitBreakerLib to reduce bytecode size.

On top of #1921 to keep track of bytecode improvements.

Results

hh compile && cat artifacts/contracts/managed/ManagedPool.sol/ManagedPool.json | jq -r '.deployedBytecode' | wc --chars | awk '{print (($1-2)/2)/1024}':

  • Base: @ a2986ea: 27,7603
  • This change: 25,1626

@jubeira jubeira requested a review from nventuro October 20, 2022 13:20
@jubeira jubeira marked this pull request as draft October 20, 2022 13:26
@jubeira jubeira marked this pull request as ready for review October 20, 2022 14:57
nventuro
nventuro approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I like how small the change is. We'll want to revert this after deployment, maybe open an issue for that?

@jubeira jubeira mentioned this pull request Oct 20, 2022
Open
Base automatically changed from external-math to master October 20, 2022 16:43
@TomAFrench
Copy link
Contributor

Merging master into this now.

@TomAFrench
Merge branch 'master' into external-pow-circuit-breakers
7b47e0f 
* master:
  Create external WeightedMath contract (#1921)
  Remove base recovery mode implementation (#1926)
  refactor: standardize "not implemented" error (#1927)
  style: linter (#1928)
@jubeira jubeira merged commit 3c599f7 into master Oct 20, 2022
@jubeira jubeira deleted the external-pow-circuit-breakers branch October 20, 2022 17:06
TomAFrench added a commit that referenced this pull request Oct 20, 2022
@TomAFrench
Merge branch 'master' into external-add-remove
602879a 
* master:
  test: add smoke tests for circuit breakers in ManagedPool (#1929)
  Make calcAdjustedBound external (#1930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jubeira @TomAFrench @nventuro