Merge master with UnitTests and Code Coverage #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getCalendarWithTime, isWithinRange method tested
small modifications in HabitoDateUtils unit tests
Unit tests written for Habit modell class Removed final modifier from HabitRecord
…t classes to increase code coverage.
Bugfix: HabitoStringUtils.capitalize method crashed when passed empty string as parameter.
…to increase code coverage.
…t method names, removed unused imports and variables, corrected a typo)
…class references, renamed methods to start with lowercase letters)
balazsczap
reviewed
May 4, 2017
| @@ -5,7 +5,7 @@ | |||
| public final class HabitoStringUtils { | |||
|
|
|||
| public static String capitalized(@NonNull final String string) { | |||
| return string.substring(0, 1).toUpperCase() + string.substring(1); | |||
| return string.isEmpty() ? string : string.substring(0, 1).toUpperCase() + string.substring(1); | |||
balazsczap
approved these changes
May 4, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to merge master with the added tests, modifications, bugfixes