-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated warnings during initial install of Sailsjs on Windows 7 #3812
Comments
Hi @SilverPaladin! It looks like you missed a step or two when you created your issue. Please edit your comment (use the pencil icon at the top-right corner of the comment box) and fix the following:
As soon as those items are rectified, post a new comment (e.g. “Ok, fixed!”) below and we'll take a look. Thanks! If you feel this message is in error, or you want to debate the merits of my existence (sniffle), please contact inquiries@treeline.io. |
Ok, fixed! |
Did you test if the installation was successful? For me the log message just looks like a bunch of warnings that can be ignored. |
Yes everything works. The minmatch seems like a security issue however. Seeing a bunch of warnings during install somehow does not inspire confidence. :) |
@SilverPaladin re security issue: We're using minimatch as a dev dependency, via Grunt. So luckily, the vulnerable code path never touches production Sails apps. For a detailed breakdown, see: http://blog.sailsjs.org/post/146087338282/node-security-advisory-for-socketio-v146-and Since updating grunt-sync has caused usability issues and race conditions with other plugins in the past, we're trying to be really careful about bumping any Grunt dependency until we've seen it work perfectly on our own projects for a few weeks. We haven't gotten there yet. Re perception: totally understand. Since it's a purely aesthetic thing, it's super low on the priority list, but I'm chipping away at it when I have time. Like @abisz said, you can ignore the deprecation warnings. We keep a close eye on security advisories (we're using Sails.js for all of our own critical production systems, fwiw), and if anything pops up, we deal with it ASAP. More background on that here and here. Thanks! |
(btw I think I nabbed the lodash one this morning w/ balderdashy/sails-build-dictionary@4723474 -- haven't gone through and given it another pass yet to see what shows up) |
@SilverPaladin,@sailsbot,@abisz,@mikermcneil: Hello, I'm a repo bot-- nice to meet you! It has been 30 days since there have been any updates or new comments on this page. If this issue has been resolved, feel free to disregard the rest of this message and simply close the issue if possible. On the other hand, if you are still waiting on a patch, please post a comment to keep the thread alive (with any new information you can provide). If no further activity occurs on this thread within the next 3 days, the issue will automatically be closed. Thanks so much for your help! |
I just installed sails and got these warnings on my cmd.
From the posts above looks like we can continue to create a project. But just not sure why are these older versions still used and what are the implications. Or should they be updated. |
Hey @Sid6555 I understand your concern.
See balderdashy/sails-docs@32305e4 (and the two linked threads) for some more background info. |
@Sid6555 @SilverPaladin btw re:
Definitely-- they're confusing and scary to folks who are getting started with Sails, plus they make it hard to actually see any real problems. Expect to see all of them cleared out when we release Sails v1.0 later this year. And if I ever forget about all of this pain, and use |
@SilverPaladin,@sailsbot,@abisz,@mikermcneil,@Sid6555: Hello, I'm a repo bot-- nice to meet you! It has been 30 days since there have been any updates or new comments on this page. If this issue has been resolved, feel free to disregard the rest of this message and simply close the issue if possible. On the other hand, if you are still waiting on a patch, please post a comment to keep the thread alive (with any new information you can provide). If no further activity occurs on this thread within the next 3 days, the issue will automatically be closed. Thanks so much for your help! |
[Fixes #3812] Istanbul 0.4.1 is using a module which uses the deprecated minimatch@…
Sails version: 0.12.4
Node version: 4.4.7
NPM version: 2.15.8
Operating system: Windows 7 Pro 64bit
Installing on windows 7 64 bit with the command:
npm -g install sails
produces the following:
The text was updated successfully, but these errors were encountered: