req.param() is broken for falsey params #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example if you posted data `{ isPirate: false }` and you run `req.param('isPirate')` from a controller, you'd get `undefined` returned as you didn't specify a `defaultValue` - so basically you couldn't post params that where === false. I think this edit captures the spirit of the OR guard used previously.
|
if anyone is interested a temporary workaround for this: instead of using |
jub3i
changed the title
|
+1 |
|
Thanks @jub3i! |
mikermcneil
added a commit
that referenced
this pull request
Mar 31, 2015
req.param() is broken for boolean false params
jub3i
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example if you posted data
{ isPirate: false }and you runreq.param('isPirate')from a controller, you'd getundefinedreturned as you didn't specify adefaultValue- so basically you couldn't post params that where === false. I think this edit captures the spirit of the OR guard used previously. If your happy with this, I would be ok with writing a test... if needed.