Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make default responses work when views hook disabled #2770

Closed
wants to merge 1 commit into from
Closed

make default responses work when views hook disabled #2770

wants to merge 1 commit into from

Conversation

enkows
Copy link
Contributor

@enkows enkows commented Mar 21, 2015

res.guessView and res.view is always undefined when views hook is disabled.

@CWyrtzen CWyrtzen assigned sgress454 and unassigned irlnathan Apr 20, 2015
@sgress454
Copy link
Member

Hi @enkows, this looks good. Would love to see tests for this but it looks like we don't have tests for the responses hook in general, so I'll see about that.

@sgress454
Copy link
Member

Sorry for the delay. Ended up going with a somewhat simpler approach here, and merging this into the generator that creates the responses. Thanks for bringing this to our attention though!

@sgress454 sgress454 closed this Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgress454 sgress454

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enkows @sgress454 @tjwebb @irlnathan @CWyrtzen