don't send stack track back for body parse errors when environment is production #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nwhatt! |
|
You're on fire @sgress454 :) One thing to note, shouldn't it move down 2 lines? Now the error doesn't get logged either. |
|
Ah, good call. I thought that was consistent with what we were doing in responses, but looks like we're logging the error there even in production (which makes sense). |
sgress454
added a commit
that referenced
this pull request
Dec 23, 2015
… production env (just not sent w/ response) refs #3347
|
:) Still on fire though! |
ctartist621
pushed a commit
to ctartist621/sails
that referenced
this pull request
Feb 3, 2016
… production env (just not sent w/ response) refs balderdashy#3347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what if any tests should be updated for this.