Skip to content
This repository has been archived by the owner on Aug 13, 2021. It is now read-only.

Calling synchronous function in async.eachSeries causes maximum call stack error #2

Closed
ilia-khaustov opened this issue Nov 17, 2014 · 3 comments

Comments

@ilia-khaustov
Copy link

More of this bug here - https://github.com/balderdashy/waterline/issues/733

There is synchronous call in buildChildBuffers function in the file populateBuffers.js, line 68. This problem is widely covered here - caolan/async#588. I guess it would be enough to change line 68 from nextParent() to async.setImmediate(nextParent).

@mikermcneil
Copy link
Member

would be enough to change line 68 from nextParent() to async.setImmediate(nextParent).

Perfect- PR welcome, thanks!

@ilia-khaustov
Copy link
Author

What do you mean by PR? Fun fact: Github is blocked in Russia due to a
number of texts describing suicide methods.

2014-12-04 0:18 GMT+07:00 Mike McNeil notifications@github.com:

would be enough to change line 68 from nextParent() to
async.setImmediate(nextParent).

Perfect- PR welcome, thanks!


Reply to this email directly or view it on GitHub
#2 (comment)
.

@devinivy
Copy link
Contributor

I moved your first comment over to #3 where there is some more conversation. Closing this as a duplicate.

Also, PR stands for "pull request" :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants