typings: Add the release versioning properties #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
force-pushed
the
release-versioning
branch
from
b692366
to
cdd60ea
Compare
thgreasi
force-pushed
the
release-versioning
branch
3 times, most recently
from
4b12bfa
to
d53b630
Compare
Setting a 3-digit semver to the release.semver field is the suggested approach, instead of setting the release.release_version field. This fixes the unique constraint issue that release_version was often causing to users, since in case a duplicate semver is provided, the backend will auto-increment the revision field of the release. A composite release.version field is also added, which has a raw field with the complete unique version of the release. Change-type: minor Depends-on: balena-io/balena-api#3249 See: https://www.flowdock.com/app/rulemotion/r-supervisor/threads/JN2-gnspQ-v6WaeWCvm9T8NYDY1 HQ: https://jel.ly.fish/8ea1c390-9a85-402d-978c-4d31dcb0d235 Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
Setting a 3-digit semver to the release.semver field is the suggested approach. Change-type: patch Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
thgreasi
force-pushed
the
release-versioning
branch
from
d53b630
to
ad635d4
Compare
|
@balena-ci I self-certify! |
ghost
merged commit 
ghost
approved these changes
Aug 16, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a 3-digit semver to the release.semver field
is the suggested approach, instead of setting the
release.release_version field. This fixes the unique
constraint issue that release_version was often
causing to users, since in case a duplicate semver is
provided, the backend will auto-increment the
revision field of the release. A composite
release.version field is also added, which has a raw
field with the complete unique version of the release.
Also deprecates the release.release_version property.
Change-type: minor
Depends-on: https://github.com/balena-io/balena-api/pull/3249
See: https://www.flowdock.com/app/rulemotion/r-supervisor/threads/JN2-gnspQ-v6WaeWCvm9T8NYDY1
HQ: https://jel.ly.fish/8ea1c390-9a85-402d-978c-4d31dcb0d235
Signed-off-by: Thodoris Greasidis thodoris@balena.io
Contributor checklist