Fix migration and migration status typings.
#747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-
reviewed
Mar 21, 2024
| return sbvrUtils.sbvrTypes.JSON.fetchProcessing(data.executed_migrations); | ||
| return sbvrUtils.sbvrTypes.JSON.fetchProcessing( | ||
| data.executed_migrations, | ||
| ) as string[]; |
There was a problem hiding this comment.
Is this cast necessary? Can it be satisfies instead?
There was a problem hiding this comment.
@Page-
No as it doesn't satisfy.
Also a type guard isn't working with the current typings and typescript inferencing capabilities.
Left a comment and leave it as a cast.
Change-type: patch Signed-off-by: Harald Fischer <harald@balena.io>
fisehara
force-pushed
the
fisehara/fix-migration-typings
branch
from
a6163f3
to
6fcdec7
Compare
thgreasi
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch